Changed return types of ceil, floor, round and (%) to return Int.

purescript-deprecated / purescript-math

Math functions

BSD 3-Clause "New" or "Revised" License

19 stars 20 forks source link

Closed jutaro closed 8 years ago

jutaro commented 9 years ago

Seems obvious to me.

garyb commented 9 years ago

This has been raised a few times, but there are a few problems doing this:

(%) intentionally operates on Numbers, as it's the only way to get modulo behaviour for non-Ints. You can already do this with mod for Int.
Using Int for the others restricts the acceptable values they can operate on to the range of Int32, significantly smaller than the range of integers that Number can safely represent.

garyb commented 9 years ago

Also 0.5 % 0.7 does not produce an Int, so the type isn't right for that either :smile:

paf31 commented 9 years ago

We should probably document those functions to explain the types :)

paf31 commented 9 years ago

Maybe these belong in -integers?

garyb commented 9 years ago

Yeah, that would make sense.

hdgarrood commented 8 years ago

We have floor, ceil, and round with the types @jutaro wanted in integers now, so I think this can be closed.