Hi-Angel
commented
1 month ago Each error is being fixed in its own commit.
Though I have two separate commits for fixing "unused lexical variable": one is a trivial rename of the arguments, and the other is removing let-bindings with a unused variable. The latter involves changing indentation, so I figured if there'd be a regression, would be better to have this change separated (but ofc hopefully there won't be any, shouldn't be at least 😊).
kritzcreek
Per discussion here, I decided to fix byte-compilation errors that are currently present in the package. As a bonus, this enables lexical binding everywhere, so Emacs will have better introspection into the package, thus enabling more optimizations.
Each error is being fixed in its own commit.
On my latest Emacs from upstream this branch currently passes with no errors.