search

purescript-halogen / purescript-halogen-vdom

An extensible virtual-dom library for PureScript.
Apache License 2.0
58 stars 25 forks source link

Nullify props on removal #12

Closed natefaubion closed 7 years ago

natefaubion commented 7 years ago

I've decided to use void 0, since this is equivalent to other props implementations in various JS virtual-dom libraries. Otherwise we should probably be using attributes more, rather than props.

garyb commented 7 years ago

This works better than removeAttribute too? I guess maybe that doesn't work because properties aren't attributes?

natefaubion commented 7 years ago

It has edge cases, but it does the same thing as other libraries (which would have the same edge cases). I don't think the answer is to treat props as attributes. I think the answer it to just use attributes more often if it's a problem.