search

purescript-halogen / purescript-halogen

A declarative, type-safe UI library for PureScript.
https://purescript-halogen.github.io/purescript-halogen/
Apache License 2.0
1.54k stars 218 forks source link

virtual-dom hook renderer is inefficient #171

Closed garyb closed 9 years ago

garyb commented 9 years ago

@natefaubion again:

https://github.com/slamdata/purescript-halogen/blob/727e5b83855763f65c2a0194779f7484f86c7817/src/Halogen/Internal/VirtualDOM.js#L38-L48

We currently create a new Hook class every time we create a hook, which is pretty unnecessary.

garyb commented 9 years ago

Fixed by @natefaubion during the changes for #196