search

purescript-node / purescript-node-fs

Node.js file I/O for purescript
MIT License
33 stars 34 forks source link

Feature/async incremental #22

Closed timbod7 closed 8 years ago

timbod7 commented 8 years ago

I've included a simple script I used for testing.

It would be nice to have a test suite for this library

hdgarrood commented 8 years ago

Great, thanks very much! I just have a couple of tweaks that I want to do before I release this.

timbod7 commented 8 years ago

I just have a couple of tweaks that I want to do before I release this.

Will this include adding the new Buffer effect type to the signature of the relevant functions in this package?

Yesterday I wrote code that looks like this:

do
      let buf = create size
      fdNext fd buf
      pure buf

which makes me unhappy.

hdgarrood commented 8 years ago

Yes. Also, one of those tweaks is updating to node-buffer ^0.2.0, where create returns an Eff action instead of being a pure function (which is a lie).