search

purescript-react / purescript-react-basic-dom

https://pursuit.purescript.org/packages/purescript-react-basic-dom
Apache License 2.0
11 stars 19 forks source link

missing controls attr in video #1

Closed mananamenos closed 4 years ago

mananamenos commented 4 years ago

Hi, I've noticed that video does not include controls attribute in Generated.purs. It should be somewhere here: https://github.com/lumihq/purescript-react-basic-dom/blob/main/src/React/Basic/DOM/Generated.purs#L17352

mananamenos commented 4 years ago

Hi @spicydonuts, any news on this issue? Why doesn't controls attribute get generated (i could not figured that out looking at the project's source)? In the meanwhile, i suppose i should clone the project and just add the controls attribute by hand. Thanks

megamaddu commented 4 years ago

Sorry, I looked at it briefly while refactoring things but I haven't figured it out yet. Hopefully I can get to it later this week.

megamaddu commented 4 years ago

@mananamenos I think I found the issue. Does this PR look right to you?

mananamenos commented 4 years ago

Hi @spicydonuts, i should have seen this. Thank you!