search

purescript-react / purescript-react-basic-dom

https://pursuit.purescript.org/packages/purescript-react-basic-dom
Apache License 2.0
11 stars 18 forks source link

`unselectable` prop causes runtime warnings #33

Open ntwilson opened 2 years ago

ntwilson commented 2 years ago

When I make a table with unselectable: true, I get a warning from React:

Warning: Received true for a non-boolean attribute unselectable. If you want to write it to the DOM, pass a string instead: unselectable="true" or unselectable={value.toString()}.

I'm using React & React-DOM v 17.0.2.

Would you consider changing unselectable to String? Or is there a reason that I should ignore the warning from React? It does appear that unselectable: true works, but unselectable: false doesn't. I'm guessing if the unselectable prop is present at all, it just sets it to not be selectable, despite the value you give it.
If the warning should be ignored, maybe you could consider changing unselectable to Unit, so it's more clear that it's mere presence is what affects the behavior?

mjrussell commented 2 years ago

This seems like a bug and something we should probably fix to use the string, at least before its passed into react proper