search

purescript-react / purescript-react-basic-dom

https://pursuit.purescript.org/packages/purescript-react-basic-dom
Apache License 2.0
11 stars 18 forks source link

Update Concurrent.js #43

Closed i-am-the-slime closed 2 years ago

i-am-the-slime commented 2 years ago 
✘ [ERROR] The symbol "createRoot" has already been declared

    output/React.Basic.DOM.Concurrent/foreign.js:6:16:
      6 │ export function createRoot(element) {
        ╵                 ~~~~~~~~~~

  The symbol "createRoot" was originally declared here:

    output/React.Basic.DOM.Concurrent/foreign.js:2:6:
      2 │ const createRoot = ReactDOM.createRoot || ReactDOM.unstable_createRoot;
        ╵       ~~~~~~~~~~
i-am-the-slime commented 2 years ago

Funnily esbuild does not work with server.js but only server because there's a module definition.

andys8 commented 2 years ago

Cool, would solve the second issue mentioned in https://github.com/lumihq/purescript-react-basic-dom/issues/42#issue-1289387789

mjrussell commented 2 years ago

@i-am-the-slime we can close this now that #44 is merged right?