Closed andys8 closed 2 years ago
package-lock.json
ReactDOMClient
Concurrent
I was thinking about adding tests, but because they're executed with node (which needs faking a browser) we're not winning much here. I did try out the current branch and it seemed to work fine for the good case: https://github.com/andys8/type-signature-com/commit/51ad716cb7afedd88f9129ce33e3cc8ea81e2fc4
There is a handful of older functions that are still working, but will result in a deprecation warning. I ended up adding a deprecation warning to these in ReactDOM.
ReactDOM
Very nice!
Thank you @andys8! Really appreciate this and thanks especially for adding the warnings for the deprecations.
Changes
package-lock.json
)ReactDOMClient
Concurrent
References
Tests
I was thinking about adding tests, but because they're executed with node (which needs faking a browser) we're not winning much here. I did try out the current branch and it seemed to work fine for the good case: https://github.com/andys8/type-signature-com/commit/51ad716cb7afedd88f9129ce33e3cc8ea81e2fc4
Warning
There is a handful of older functions that are still working, but will result in a deprecation warning. I ended up adding a deprecation warning to these in
ReactDOM
.Related