search

purescript-react / purescript-react-basic-dom

https://pursuit.purescript.org/packages/purescript-react-basic-dom
Apache License 2.0
11 stars 18 forks source link

Change the `_aria` prop from being an Object to inline props #46

Open i-am-the-slime opened 2 years ago

i-am-the-slime commented 2 years ago

I think I had mentioned this in the past and if memory serves well @megamaddu concurred:

aria attributes are being handled like data attributes. That is, one can supply an Object String as _aria to most (all?) basic components and they will be correctly injected. But contrary to data- attributes, the set of valid aria- attributes is well-defined and not free for the author to choose.

As a reference: Here's the list:

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes

mjrussell commented 2 years ago

Sounds like a good improvement. I was wondering if any other purescript libraries had done this already or if there might be a small JS library that we could import all the names from. I don't see one unfortunately though