search

purescript-react / purescript-react-basic-dom

https://pursuit.purescript.org/packages/purescript-react-basic-dom
Apache License 2.0
11 stars 19 forks source link

Switch to Spago for tooling #7

Closed maxdeviant closed 2 years ago

maxdeviant commented 4 years ago

Are we open to switching to Spago for the build tooling? If so, I'd be happy to open a PR with the change.

megamaddu commented 4 years ago

I was under the impression we still needed the bower.json for now so it'd just be redundant to have both, but I don't know much about it tbh. All the react-basic libraries are available in the package set though, so it only matters if you're working on this project.

hdgarrood commented 4 years ago

Personally I think it makes the most sense to stick with bower for authoring libraries for the time being; you do indeed still need bower.json. See https://discourse.purescript.org/t/documentation-improvement-efforts/1400/19

maxdeviant commented 4 years ago

so it only matters if you're working on this project.

Opening #6 is what prompted me to open the issue, as I've only ever used Spago, so it wasn't immediately obvious how to build the library :smile:

Thanks for the info @hdgarrood, that's very helpful to know.

Should I go ahead and close this issue since we need Bower for the near-term future?

megamaddu commented 4 years ago

This might actually make sense now with the spago bump-version command.. I'd rather have spago manage the individual versions using the latest package set if that's how most people are installing these libraries anyway.