The existing version of useEffectAlways is passing unit as a dependency. The memoizedKey here is therefore always the same, referentially-equal value (despite eq constantly returning false).
exports.useEffect_ = function (eq, deps, effect) {
var memoizedKey = exports.useMemo_(eq, deps);
React.useEffect(effect, [memoizedKey]);
};
I don't know if there's a way around this using current API of react-basic-hooks, so the proposed (not ideal 😕 ) solution in this PR is to add a new foreign function useEffectAlways_ that omits the dependency array.
The existing version of
useEffectAlwaysis passingunitas a dependency. ThememoizedKeyhere is therefore always the same, referentially-equal value (despiteeqconstantly returningfalse).Because the
memoizedKeynever changes, this effect will only run once, not on every render (as I think was intended). This behavior can be witnessed in this example: https://codesandbox.io/s/use-effect-unit-dep-8ec3l?file=/src/App.jsI don't know if there's a way around this using current API of
react-basic-hooks, so the proposed (not ideal 😕 ) solution in this PR is to add a new foreign functionuseEffectAlways_that omits the dependency array.Fixes #25