Fix parameter order in CSSStyleDeclaration

purescript-web / purescript-web-cssom

Type definitions and low level interface implementations for the CSS Object Model

MIT License

9 stars 4 forks source link

Fix parameter order in CSSStyleDeclaration #12

Closed theqp closed 2 years ago

theqp commented 2 years ago

This is a breaking change.

Checklist:

[ ] Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
[ ] Linked any existing issues or proposals that this pull request should close
[ ] Updated or added relevant documentation
[ ] Added a test for the contribution (if applicable)

thomashoneyman commented 2 years ago

@garyb I see the 👍 -- is this something we want to standardize on? The foreign-import object going last?

garyb commented 2 years ago

Not so much the foreign-import object going last as "the thing being operated on", as that's the convention generally everywhere - collections, refs, is (should) be the case with the other web libraries, etc. 🙂

JordanMartinez commented 2 years ago

Is this another breaking change to make in v0.15.0?

thomashoneyman commented 2 years ago

Let's do it!