Use `var` instead of `const`

purescript / purescript-prelude

The PureScript Prelude

BSD 3-Clause "New" or "Revised" License

163 stars 88 forks source link

Use `var` instead of `const` #296

Closed triallax closed 2 years ago

triallax commented 2 years ago

Description of the change

Replace const with var, since esbuild cannot lower const and let to var at the moment, preventing transpiling to ES5.

Checklist:

[x] Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
[ ] Linked any existing issues or proposals that this pull request should close
[ ] Updated or added relevant documentation
[ ] Added a test for the contribution (if applicable)

natefaubion commented 2 years ago

AFAIK, the ecosystem in general has moved over to const with the 0.15 release. While esbuild may not support lowering these to ES5, many other bundlers and plugins do. I personally don't think that we should retroactively make this change across the ecosystem.

triallax commented 2 years ago

@natefaubion that's fair.