Added `Choice` and `Strong`.

purescript / purescript-profunctor

Profunctor type classes and data structures

BSD 3-Clause "New" or "Revised" License

33 stars 13 forks source link

Added `Choice` and `Strong`. #1

Closed joneshf closed 9 years ago

joneshf commented 9 years ago

bump

paf31 commented 9 years ago

Looks fine to me. I'm a little sad about the ticks in the names though. We really need qualified names for type class members.

@garyb ?

garyb commented 9 years ago

I think there's something wrong with GitHub notifications for me, or I'm oblivious ;) didn't even notice this before...

Is it really a problem to call it first? I'd rather qualify on import personally. Isn't Profunctor more fundamental than Arrow too, so if either should be prime'd it should be Arrow.

joneshf commented 9 years ago

Guess it's time to read http://www-mmm.is.s.u-tokyo.ac.jp/~ichiro/papers/fromComptoComp.pdf and friends.

garyb commented 9 years ago

Can we just go ahead and change these to first and second or is that going to cause problems that can't be fixed by qualification?

garyb commented 9 years ago

Thanks! Sorry it took so long to get to...

joneshf commented 9 years ago

No worries :).