search

purescript / purescript-record

Functions for working with records and polymorphic labels
BSD 3-Clause "New" or "Revised" License
70 stars 31 forks source link

Fix merge #72

Closed JordanMartinez closed 3 years ago

JordanMartinez commented 3 years ago

Fixes #55

JordanMartinez commented 3 years ago

I'm not sure what should be changed in the docs for Builder.merge

kl0tl commented 3 years ago

I may have misunderstood but wasn’t the issue talking about renaming Record.Builder.merge to Record.Builder.withDefaults and adding a Record.Builder.merge function behaving like Record.merge?

JordanMartinez commented 3 years ago

Based on Harry's comment here, I don't think so. Seems like Record.merge would be renamed and Builder.merge should override values that exist in the original one (or something).

hdgarrood commented 3 years ago

@kl0tl has it right. Nothing in Record should be changing here.

JordanMartinez commented 3 years ago

Ok. I'll close this and let someone else take care of it.