search

purescript / purescript-st

The ST effect, for safe local mutation
BSD 3-Clause "New" or "Revised" License
25 stars 25 forks source link

Release with `v` prefix #28

Closed f-f closed 4 years ago

f-f commented 4 years ago

The fact that the latest release doesn't have a v prefix is causing a build failure in package-sets. And indeed, that version number doesn't conform to the rules for adding a package to the set

Could we cut a v4.2.0 release?

hdgarrood commented 4 years ago

Is there a reason to increment the version number? The tag would be pointing at the same commit presumably, so my first thought would have been to call it v4.1.0.

f-f commented 4 years ago

@hdgarrood I'd just increment the version number to avoid any possible confusion with SemVer ordering. I guess we could be fine with v4.1.1 too.

hdgarrood commented 4 years ago

Fair enough. I think v4.1.1 is more appropriate, since there are no code changes.

hdgarrood commented 4 years ago

Done!

garyb commented 4 years ago

Apologies. Not sure why after making hundreds or maybe thousands of library releases I suddenly dropped the v. :smile:

f-f commented 4 years ago

Thank you both! :slightly_smiling_face: