purescript / purescript-strings

String utility functions, Char type, regular expressions.
BSD 3-Clause "New" or "Revised" License
54 stars 71 forks source link

Regex match should give NonEmptyArray #105

Closed vinothkr closed 6 years ago

vinothkr commented 6 years ago

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/match

States that if there is a match, the first element of the array is the entire match. In which case there is atleast 1 element. Should we make this return Maybe NonEmptyArray (Maybe String)?

garyb commented 6 years ago

👍

Resolved in the 0.12 branch.