search

purescript / purescript-strings

String utility functions, Char type, regular expressions.
BSD 3-Clause "New" or "Revised" License
54 stars 71 forks source link

reexport Data.String.CodeUnits #109

Closed CarstenKoenig closed 6 years ago

CarstenKoenig commented 6 years ago

those reexports are missing - for example charAt is not found right now

garyb commented 6 years ago

charAt and the like don't really make sense to re-export, as none of the other functions will able to use Char. Importing CodeUnits explicitly for the Char functions was the intention.

CarstenKoenig commented 6 years ago

ok I see - I already adapted the one occurrence I found (https://github.com/purescript-contrib/purescript-argonaut-codecs/pull/42) - sorry to bother you - I guess I should close this then

michaelficarra commented 6 years ago

@CarstenKoenig This is actually a really good thing. This will help people find Unicode bugs in their projects. For instance, the usages of charAt in https://github.com/purescript-contrib/purescript-argonaut-codecs/pull/42 are actually bugs.