Quote strings in Show instances

purescript / purescript-strings

String utility functions, Char type, regular expressions.

BSD 3-Clause "New" or "Revised" License

54 stars 71 forks source link

Closed Rufflewind closed 7 years ago

Rufflewind commented 7 years ago

Usually in Haskell, strings are shown with quotes, so I presume PureScript follows the same convention.

paf31 commented 7 years ago

Patch, I agree.

paf31 commented 7 years ago

Thanks!

garyb commented 7 years ago

Too late now, but I would have voted for patch also 😄

paf31 commented 7 years ago

I did make a patch change, I bumped the version to 3.3.1.

garyb commented 7 years ago

Yeah I know, I just meant my comment was too late to have swayed it were it not unanimous.

paf31 commented 7 years ago

Sorry for rushing, it just seemed harmless enough in this case either way, since people shouldn't be relying on (bad) Show instances anyway really.

garyb commented 7 years ago

Haha no worries, it was supposed to be a joke... I should have stayed quiet 😉