Show Instance for CodePoints

purescript / purescript-strings

String utility functions, Char type, regular expressions.

BSD 3-Clause "New" or "Revised" License

54 stars 71 forks source link

Closed csicar closed 6 years ago

csicar commented 6 years ago

this is useful for creating examples for the documentation

hdgarrood commented 6 years ago

Great, thanks! There's just a few things I'd like to be done before merging:

Fix the warning which is causing CI to fail
Add purescript-integers to bower.json to explicitly depend on it; this isn't absolutely necessary since we're already pulling it in transitively but if we do it now I think it means we're less likely to run into dependency issues later
Add a couple of basic tests for this Show instance.

hdgarrood commented 6 years ago

Thank you!