search

purescript / purescript-typelevel-prelude

Types and kinds for basic type-level programming
BSD 3-Clause "New" or "Revised" License
63 stars 21 forks source link

import boolean from prim #41

Closed justinwoo closed 5 years ago

justinwoo commented 5 years ago

I guess this will be in some upcoming 0.12.x release https://github.com/purescript/purescript/pull/3389

So this cannot be merged for 0.12.1 but sometime after

justinwoo commented 5 years ago

Relevant referrers of typelevel-prelude:

"foreign-object"
"react"
"react-basic"
"record"
"record-format"
"simple-json"
"typelevel"
"variant"

justinwoo

"choco-pie"
"expect-inferred"
"jajanmen"
"kancho"
"milkis"
"record-extra"
"tortellini"
"type-isequal"
hdgarrood commented 5 years ago

I suppose this is reallya breaking change then, since we are dropping support for 0.12.1 and below? Perhaps we should wait a little bit and see if there are any other breaking changes we’d like to do at the same time?

justinwoo commented 5 years ago

Yeah, I think this should be a new major release but it won't require consumers to do more than upgrade the library version they use. I don't think there are any other changes queued up though?

hdgarrood commented 5 years ago

If we are doing a breaking release I would be very keen for it to contain a commit which resolves #43.

hdgarrood commented 5 years ago

But other than that, yes, everything else looks like it would be a semver minor change.

hdgarrood commented 5 years ago

I take that back, we'd need https://github.com/purescript/purescript/issues/3391 to be able to address #43 sensibly.

justinwoo commented 5 years ago

Will someone merge this sometime?

LiamGoodacre commented 5 years ago

Thanks @justinwoo

justinwoo commented 5 years ago

thanks!