Upload fails when using semver ranges

purescript / pursuit

Website for hosting and searching PureScript API documentation

https://pursuit.purescript.org/

Other

169 stars 47 forks source link

Upload fails when using semver ranges #390

Closed garyb closed 5 years ago

garyb commented 5 years ago

For example 2 - 3. It may also be if you just specify a single number (e.g. 6, which is equivalent to ^6.0.0).

When pushing with pulp the result something like:

* Uploading documentation to Pursuit...
* Failed reading: not a valid json value
* ERROR: Expected an HTTP 201 response from Pursuit, got: 400

garyb commented 5 years ago

Update: it seems to be any version ranges actually, it also fails for things like >=2.0.0 <4.0.0

hdgarrood commented 5 years ago

I doubt that this is related to version ranges, since we don't attempt to parse them at all. The only place they're used, as far as I'm aware, is the "dependencies" list in the sidebar. See e.g. https://pursuit.purescript.org/packages/purescript-react-dom/6.1.0 which has been successfully uploaded with a >=x.y.z <a.b.c range.

garyb commented 5 years ago

I was able to publish locally so I suspect CI is using an old version of pulp or something; perhaps it's uploading old style manifests. False alarm! :wink: