search

purescript / pursuit

Website for hosting and searching PureScript API documentation
https://pursuit.purescript.org/
Other
170 stars 47 forks source link

Update to v0.15.4 #468

Closed sigma-andex closed 2 years ago

sigma-andex commented 2 years ago

Update pursuit to 0.15.4.

Apparently barrier, the library to render badges, is hopelessly outdated and doesn't work with GHC 9.2.3. I haven't found any replacement for rendering badges. Not sure if anyone wants to fork, update and maintain this library? Otherwise I would propose to drop badge support.

sigma-andex commented 2 years ago

@PureFunctor could you check if my updates in src/SearchIndex.hs are correct?

purefunctor commented 2 years ago

Woops, CI breaks because I force pushed on my barrier fork 😅. Updating the commit hash to PureFunctor/barrier@db5e27c should make this work.

sigma-andex commented 2 years ago

Ok updated it to this commit

sigma-andex commented 2 years ago

@JordanMartinez can you re-run the pipeline?

JordanMartinez commented 2 years ago

@JordanMartinez can you re-run the pipeline?

Restarted. Sorry about the delay.

sigma-andex commented 2 years ago

Next try :D

sigma-andex commented 2 years ago

Ok I think now it should be good :D

sigma-andex commented 2 years ago

Once this is good, it would be great to get #469 approved & merged as well and then do a deployment

JordanMartinez commented 2 years ago

@garyb Assuming this builds, can I get another approval here? I'm not sure if @PureFunctor's approval (if it was given) would count due to not being a core team member. If I'm wrong, feel free to correct me.

sigma-andex commented 2 years ago

@garyb Assuming this builds, can I get another approval here? I'm not sure if @PureFunctor's approval (if it was given) would count due to not being a core team member. If I'm wrong, feel free to correct me.

How about promoting @PureFunctor to the core team so you can be sure about it? :)

JordanMartinez commented 2 years ago

Thanks all!