search

purescript / pursuit

Website for hosting and searching PureScript API documentation
https://pursuit.purescript.org/
Other
170 stars 47 forks source link

Insufficient contrast (according to WCAG) #93

Closed hdgarrood closed 7 years ago

hdgarrood commented 9 years ago

See: http://webaim.org/resources/contrastchecker/

The following have insufficient contrast, according to WCAG:

Presumably the links issue also affects the main PureScript website as well.

Unfortunately if you simply darken the link colour until it passes, it becomes a rather horrible brown. So I'm not really sure how to proceed here.

grossbart commented 7 years ago

I experimented with finding a good color for the links using this contrast finder tool.

However, what happens when we increase the contrast of the links, is that they become less distinguishable from the rest of the text, i.e. we fix readability but hurt discoverability 😏

I think having the links in bold at 16px (with a darker color on hover in https://github.com/purescript/pursuit/pull/266) is sufficient for the time being. I solved the issue with the keyword color in https://github.com/purescript/pursuit/pull/266/commits/40ee7cdbb1337b9177b04322833982e8f1abbffd.

A color scheme redesign should take this accessibility issue into account. For the time being, I think this is good enough while allowing us to keep a yellow tone (the most difficult color to get good contrast on!) and I suggest to close the issue.