search

purescript / registry-dev

Development work related to the PureScript Registry
https://github.com/purescript/registry
97 stars 80 forks source link

Upgrade spago to latest #583

Closed f-f closed 1 year ago

thomashoneyman commented 1 year ago

That’s an interesting error — I wonder what changed? If you’re using the version parser you’ll want to switch to lenient parsing for things that start with a ‘v’ prefix.

MonoidMusician commented 1 year ago

Hm LegacyVersion is in app, though, and spago isn't depending on app yet (just lib and foreign).

MonoidMusician commented 1 year ago

PR: https://github.com/purescript/spago/pull/932

f-f commented 1 year ago

Yeah, this broke because we were using lenient version parsing everywhere. Spaghetto has no tests at the moment, so a few things might still break (we didn't get to exercise this code path on our work repo, as we bypass all the Node stuff)

f-f commented 1 year ago

This should do a little better now?