search

purescript / registry-dev

Development work related to the PureScript Registry
https://github.com/purescript/registry
97 stars 80 forks source link

Support exclude files #613

Closed i-am-the-slime closed 1 year ago

i-am-the-slime commented 1 year ago

Adds support for exclude files which enables colocation (#602)

excludeFiles is an array of globs. The corresponding expanded paths will be subtracted from all included paths (implicit and explicit via files).

That way it's possible to keep related files close together but not ship them in the package 🥳.

Right now this depends on a forked version of spaghetto which depends on this fork. I'm not sure in what order this could be merged.

f-f commented 1 year ago

Thanks for putting this together @i-am-the-slime! I am on holiday away from screens this week, so I'll be able to review all of this once I'm back on Sunday 🙂

f-f commented 1 year ago

@i-am-the-slime the dependency order is spago-core -> registry -> spago, so we'll want to merge a PR to spago-core first, then one to registry (this one), then one to spago

thomashoneyman commented 1 year ago

I think we should use the same names (include / exclude), which would mean changing the Manifest type (and the associated dhall spec and description in SPEC.md). If you’d like to do that, great! If you’d rather I do it since I know where all the relevant files are then I can — just let me know.

i-am-the-slime commented 1 year ago

@thomashoneyman I won't say no to this offer. Especially because I'm having trouble with the new spago in IntelliJ which is what I'm used to using these days.

thomashoneyman commented 1 year ago

I ended up going with includeFiles and excludeFiles — once I was in the code, it felt more obvious what they were. @f-f, do you want to give this a look, especially how I reworded SPEC.md?