search

purescript / registry-dev

Development work related to the PureScript Registry
https://github.com/purescript/registry
97 stars 80 forks source link

Replace sunde with node-execa #624

Closed pete-murphy closed 1 year ago

pete-murphy commented 1 year ago

Fixes #616

thomashoneyman commented 1 year ago

Hey @pete-murphy! Thanks for doing this — I've been quite busy over the past few days so I haven't reviewed beyond a cursory glance, but it looks good so far. I'll get you a proper review this week. @JordanMartinez may also have thoughts.

f-f commented 1 year ago

I will also try to give a review asap is no one else gets to it before me (we've been just really busy with the big effort in #623)

JordanMartinez commented 1 year ago

Otherwise, LGTM.

pete-murphy commented 1 year ago

Sorry for force-push, I rebased on top of latest master to resolve conflicts