Closed pete-murphy closed 11 months ago
Hey i reviewed your PR looks good to me. There is an opportunity to tweak the compression algorithm if needed. The gzip function takes a second parameter with options and you can set the compression level there with other parameters https://nodejs.org/api/zlib.html#zlibgzipbuffer-options-callback
Hey i reviewed your PR looks good to me. There is an opportunity to tweak the compression algorithm if needed. The gzip function takes a second parameter with options and you can set the compression level there with other parameters https://nodejs.org/api/zlib.html#zlibgzipbuffer-options-callback
Thanks! I have no experience optimizing compression so I have no idea what would be the best settings here and would be open to recommendations. I'm hoping that since (I think) there haven't been any issues publishing via Pulp using the default settings for zlib.createGzip
, we might be safe using the defaults here 🤞 .
I'm sorry for my slow reviews this week — I'm only somewhat available, and will be fully back online next week. I'm going to take a quick look through your PR but don't have the time right now to test it out. I promise to get this over the line by next week, however, should it appear to have no issues. Thanks for taking the time to work on this!
Thank you!
Fixes #642.