Closed f-f closed 2 months ago
At a glance this all looks like a straightforward, mechanical change. I guess we don’t have much in the way of error tests; what does the new error output look like when for example a JSON payload contains an invalid package name?
@thomashoneyman good point - I added a test to exercise the new errors!
Ah yeah, autoformatter didn't run for some reason
Not sure if we are tracking this in this repo, but we talked about doing this in the past, and we need it for https://github.com/purescript/spago/issues/1090
Maybe the most important detail here is that we are propagating the errors from the parsers into the
DecodeError
s, so that they get through to the user when parsing things like PackageNames that are too long.