purestorage / helm-charts

Pure Storage Helm Charts
Apache License 2.0
47 stars 43 forks source link

[Feature Request] Reference API token from a kubernetes secret object #172

Open yuha0 opened 4 years ago

yuha0 commented 4 years ago

Currently, the API token is specified as a string literal in PSOPlugin object in purestorage.com/v1.

Since we check in all cluster objects in a git repository, this would mean that we have to expose the token to everyone who has read permission to the repository. This is not very secure.

Kubernetes secret is designed for managing sensitive information, and there are many options to allow us to safely version control secrets in git in encrypted form.

Can we allow the token to be referenced as a, for example, v1.SecretKeySelector?

sdodsley commented 4 years ago

@caryli-ps can we look into this?

TJM commented 4 years ago

This just came up for us as well, we noticed that there was no way to get the API Token from a secret... It would require some restructuring, probably :(

sdodsley commented 4 years ago

@TJM I believe we now hold these API tokens in a secret but are not held in a secret that can be accessed by the Helm chart. This is still an open RFE