purificant / python-paseto

Platform-Agnostic Security Tokens for Python
MIT License
23 stars 1 forks source link

Support for python 3.10 #4

Closed sumitsharansatsangi closed 2 years ago

sumitsharansatsangi commented 2 years ago

Since python 3.10.0 is now released. So, please provide a support for it too. Thank you.

purificant commented 2 years ago

Good idea @sumitsharansatsangi, thank you for raising this issue.

CI pipeline is currently testing against the latest and greatest stable py3.10, I expect all code to be fully compatible with this version because of 100% test coverage.

PyPi package however is currently locked to <3.10, there will be a release soon to officially add 3.10 as well.

purificant commented 2 years ago

v0.5.1 release is now available on PyPi: https://pypi.org/project/python-paseto/ See GitHub release here: https://github.com/purificant/python-paseto/releases/tag/v0.5.1

Thank you for your feedback. :+1:

sumitsharansatsangi commented 2 years ago

Tried pip install python-paseto . But receives following error.

Using version ^0.5.1 for python-paseto

Updating dependencies
Resolving dependencies... (0.0s)

  AssertionError

  at ~/.cache/pypoetry/virtualenvs/myenv-CbAKUlE6-py3.10/lib/python3.10/site-packages/poetry/mixology/incompatibility.py:60 in __init__
       56│                     # intersection, they're mutually exclusive, making this incompatibility
       57│                     # irrelevant, since we already know that mutually exclusive version
       58│                     # ranges are incompatible. We should never derive an irrelevant
       59│                     # incompatibility.
    →  60│                     assert by_ref[ref] is not None
       61│                 else:
       62│                     by_ref[ref] = term
       63│ 
       64│             new_terms = []
purificant commented 2 years ago

@sumitsharansatsangi Please try 0.5.2

sumitsharansatsangi commented 2 years ago

@purificant , I am sorry to say but it is giving me error again.

Using version ^0.5.2 for python-paseto

Updating dependencies
Resolving dependencies... (0.0s)
Resolving dependencies... (0.1s)
  AssertionError

  at ~/.cache/pypoetry/virtualenvs/myenv-CbAKUlE6-py3.10/lib/python3.10/site-packages/poetry/mixology/incompatibility.py:111 in __str__
      107│         )
      108│ 
      109│     def __str__(self):
      110│         if isinstance(self._cause, DependencyCause):
    → 111│             assert len(self._terms) == 2
      112│ 
      113│             depender = self._terms[0]
      114│             dependee = self._terms[1]
      115│             assert depender.is_positive()
purificant commented 2 years ago

@sumitsharansatsangi Could you please share which poetry version is used? poetry --version and if you are able to share pyproject.toml? I'd like to be able to reproduce this.

sumitsharansatsangi commented 2 years ago

Poetry version 1.1.11

Created a new environment and tried with pip and it works.

└──╼ $pip install python-paseto
Collecting python-paseto
  Downloading python_paseto-0.5.2-py3-none-any.whl (13 kB)
Collecting pysodium<0.8.0,>=0.7.10
  Using cached pysodium-0.7.10-py3-none-any.whl
Installing collected packages: pysodium, python-paseto
Successfully installed pysodium-0.7.10 python-paseto-0.5.2
sumitsharansatsangi commented 2 years ago

Created a new environment again, but with poetry and it works . Installed all the previous package successfully. I don't know what is the problem in that environment. May be because I have tried first python-paseto 0.5.0 and then python-paseto 0.5.1 . Not sure. But anyhow , now it is working fine. Thanks!!

purificant commented 2 years ago

@sumitsharansatsangi Glad it works for you! There was a valid issue with installing 0.5.1 with poetry, which was resolved in 0.5.2 so thank you for reporting this!

In the future the plan is to add periodic automated tests for package install with latest versions of poetry, pip and maybe pipenv to help spot these kind of regressions.