search

purivirakarin / pe

0 stars 0 forks source link

DG: Cosmetic Bug on the Examples #10

Open purivirakarin opened 4 months ago

purivirakarin commented 4 months ago

Page 39 AddPolicy 5. should state that x is a positive integer that is smaller or larger than the list size

Screenshot 2567-04-19 at 17.25.50.png

nus-se-bot commented 4 months ago

Team's Response

The test case is to test that invalid indexes would produce a error message and thus it need not be a positive integer as a negative integer, or in this case any number that is a invalid index) would be an invalid input as well.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The current phrasing, stating 'where x is smaller or larger than the list size,' might be a bit unclear, as it doesn't explicitly state that 'x' should not be within the range of valid list indexes. To enhance clarity, it could specify that 'x' should be a 'non-positive integer or a number larger than the list size' to make it clear that valid indexes are only positive numbers within the range of the list size. This would prevent any confusion about what an invalid index is.