purivirakarin / pe

0 stars 0 forks source link

Parsing Bug: Incorrect Error Message when deleting a large-number index #2

Open purivirakarin opened 4 months ago

purivirakarin commented 4 months ago

How to reproduce Type delete 2222222222222222222222222222

Actual Invalid command format! delete: Deletes the client identified by the index number used in the displayed client list. Parameters: INDEX (must be a positive integer) Example: delete 1

Expected The client index provided is not on the list!

Screenshot 2567-04-19 at 16.18.58.png

nus-se-script commented 4 months ago

Team's Response

This was caused by extreme user behaviour as specified in the PE instructions "Problems caused by integer overflows -- apply the guideline in the previous point."

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I understand that the team marked this issue as because extreme user behavior due to an integer overflow. However, I believe the error message should accurately reflect the nature of the issue. An incorrect error message can be misleading and implies a user error rather than a system limitation. Therefore, I reject the decision because I think the error handling should be improved to handle integer overflow inputs more properly and provide a clearer message to the user. This will enhance the correctness of the application and improve the user experience.