search

purnima143 / Pluto-UI

Pluto UI is a comprehensive React UI component library designed for ecommerce websites. It provides a wide range of reusable and customizable UI elements to enhance the user experience of your online store.
MIT License
27 stars 52 forks source link

Added 6 new button styles #41

Closed ojasaklechayt closed 1 year ago

ojasaklechayt commented 1 year ago

Fixes #31

I have created and added more button styles in my PR. I have made the detailed explanation through diagram and discussion is in Issue Number: #31

Lovelyfin00 commented 1 year ago

Nice stuff you got here🎉 Just some suggestions and comments

ojasaklechayt commented 1 year ago

Nice stuff you got here🎉 Just some suggestions and comments

  • For all the buttons that are rounded, they should be inside the rounded story and can have all the colors and the large size too. And also, I don't think we need any button to have a shadow for now until the design accounts for it.

Okay, I will make the changes

ojasaklechayt commented 1 year ago

Nice stuff you got here🎉 Just some suggestions and comments

  • For all the buttons that are rounded, they should be inside the rounded story and can have all the colors and the large size too. And also, I don't think we need any button to have a shadow for now until the design accounts for it.

Updated

Lovelyfin00 commented 1 year ago

You've done a great job🎉 What I want you to do next is put all the round buttons inside of the rounded story. I don't want each of them to be a story on their own.

ojasaklechayt commented 1 year ago

You've done a great job🎉 What I want you to do next is put all the round buttons inside of the rounded story. I don't want each of them to be a story on their own.

I have made some changes. Are they appropriate ?

Lovelyfin00 commented 1 year ago

I'll review it and drop feedback. Thanks

Lovelyfin00 commented 1 year ago

Ok, I have checked it out and that's not what I meant Inside of the button story, Have a sub story called Round which is where I wrote Round Now inside of the Round story, you can populate it with different round buttons with colors instead of just a single button

tempsnip

Use this for reference https://github.com/wagtail/wagtail/blob/main/wagtail/admin/templates/wagtailadmin/shared/button.stories.tsx

ojasaklechayt commented 1 year ago

Ok, I have checked it out and that's not what I meant Inside of the button story, Have a sub story called Round which is where I wrote Round Now inside of the Round story, you can populate it with different round buttons with colors instead of just a single button

tempsnip

Use this for reference https://github.com/wagtail/wagtail/blob/main/wagtail/admin/templates/wagtailadmin/shared/button.stories.tsx

Hi! I tried doing it but I am unable to change it.

Update: I have tried changing the directory.

ojasaklechayt commented 1 year ago

@purnima143 @Lovelyfin00 have done the changes + there were some merge conflicts due to which I had to close the pr/. I have reopened it.

Lovelyfin00 commented 1 year ago

Thanks for sticking to this @ojasaklechayt You would need to open a new PR with these changes and it should be against the dev branch instead of master image

ojasaklechayt commented 1 year ago

Okay I shall close this pr then