Open nishitapande opened 1 year ago
@nishitapande Great job you've done here🎉🎉 Just some minor improvements
.jsx
extension not .js
Hey @nishitapande Please don't delete the package-lock.json file Listen to the vn I sent to you on discord
@Lovelyfin00 is it fine now?
No
It's still showing
Go to dev branch on the Pluto UI repository Copy the code inside the package-lock.json file and paste it in your package-lock.json Copy the code inside the package.json file and paste it in your package.json Check if you have any lintng tool like prettier enabled so it won't format the file on save
@Lovelyfin00 I have done the steps. but its still not showing here.
Turn off your linting tool You've got one
You need to remove the extra space in the file in the screenshots below
Then you need to do the same thing for the package-lock.json file
@Lovelyfin00 I have done all the above, but it's still showing.
It's alright I noticed you made changes to the README?
@Lovelyfin00 I haven't made the changes to readme. I was hoping to do that once all the changes are reviewed. Show I do it now
Each PR is only to be for a specific issue. This PR is for building the breadcrumb component. So any other changes or fix you want to make should be on a new issue. You have to undo the changes in any of the files that is not related to breadcrumbs
@Lovelyfin00 This PR only has files related to breadcrumbs.
There are changes to the README and .github/pull_request_template.md file. Did you at some point mistakenly delete this file .github/pull_request_template.md?
Apart from that, have you taken a look at the reviews and made all the changes?
@Lovelyfin00 no I didn't delete file .github/pull_request_template.md?
@Lovelyfin00 I have made all the changes. Do tell me if anything else needs to be changed
Ok great I'll do another testing But for now, I'll assign the product details issue to you so you can start working on it
@Lovelyfin00 ok cool. Thanks. I will start working on product detail issue
Description
Provide a brief description of the changes made in this pull request. fixes: #14 Added Breadcrumb navigation component for both dark theme and light theme.
Changes Made
List the specific changes or features implemented in this pull request.
Checklist
Screenshots (if applicable)
Add any relevant screenshots to showcase the changes made, if applicable.![dark-theme](https://github.com/purnima143/Pluto-UI/assets/89330962/621fe9d4-3b19-48ff-b0db-f0a7b80f504f)