Closed shivam-jainn closed 1 year ago
Hey @shivam-jainn Thanks for contributing ❤️, does it have a grid view as it was mentioned in issue #71 you had added image for the list view but I can't see a grid view, I wonder if you could attach that too, Or if its not go ahead and make one
Hey @shivam-jainn Thanks for contributing heart, does it have a grid view as it was mentioned in issue #71 you had added image for the list view but I can't see a grid view, I wonder if you could attach that too, Or if its not go ahead and make one
I have made some updates to the grid component and separated the grid's card and grid functionality into separate files. However, I would like to discuss how to form grids easily using Storybook.
Here's the current state of the code:
Grid Component:
data
prop, which is currently hardcoded with sample data.productGrid
class to wrap the grid.Mapping the Data:
data
array to generate the ProductGridCard
components.data
array contains properties such as description
, price
, productimage
, title
, darkmode
, and noOfStars
.ProductGridCard
component.Hardcoded Data:
data
array is hardcoded within the grid component.Next Steps and Discussion Points:
External Data Source:
Integration with Storybook:
Dynamic Data:
By addressing these points, we can enhance the grid component's flexibility, maintainability, and reusability. Let's discuss and find the best approach for our requirements.
Please review the code changes and share your thoughts. Let me know if you have any questions or if there's anything specific you'd like to discuss.
Description
I have added two new components : 1) Product List 2) Product Grid
solves issue #71
Changes Made
1) Relocated the star component to it's own component folder 2) Added Product list card 3) Added Product grid card
Testing
Went through and checked how it works on different viewports
Screenshots (if applicable)
PRODUCT GRID
product grid default
product grid dark mode
Product list
product grid default
product grid dark mode