Upgraded library to support asp.net core 3.

purplebricks / PB.ITOps.AspNetCore.Versioning

This is a convention for versioning web APIs. It extends Microsoft ASP.Net API Versioning by introducing a new convention and attributes.

Apache License 2.0

13 stars 5 forks source link

Upgraded library to support asp.net core 3. #5

Closed srpeirce closed 5 years ago

srpeirce commented 5 years ago

Some of the libraries used in the example are in RC preview. These will need upgrading soon.

byronbayer commented 5 years ago

Should we be making this change to prod if dependant packages (swagger) are still in RC?

srpeirce commented 5 years ago

@byronbayer Fair question - I agree that it isn't ideal. However, I think it's okay as it's just the consumer (Example) that is dependent on RC packages to configure the Swagger correctly.

The library has 1 dependency which is not a RC.

<ItemGroup>
        <PackageReference Include="Microsoft.AspNetCore.Mvc.Versioning" Version="[4,5)" />
    </ItemGroup>

Are you happy with that?

srpeirce commented 5 years ago

Potentially could do a pre-release package but [selfishly] given I'm leaving next week I would rather just get it in, and concentrate on upgrading the PB Goldstandard projects to dontet core 3 as I have limited time :) Albeit the gold standard API might just be a PR until the RC is finalised but should then be minimal effort for another engineer.