search

purpleidea / mgmt

Next generation distributed, event-driven, parallel config management!
https://purpleidea.com/tags/mgmtconfig/
GNU General Public License v3.0
3.62k stars 313 forks source link

Add new golangci-lint test #487

Open purpleidea opened 5 years ago

purpleidea commented 5 years ago

We use gometalinter in our tests. We'd like to switch to https://github.com/golangci/golangci-lint since the former is deprecated. This should in theory improve testing speed as well.

Patches welcome!

(Note initially, the goal would be to add a new test similar to https://github.com/purpleidea/mgmt/blob/master/test/test-gometalinter.sh and in the future, I can remove the gometalinter test.)

(If the new gometalinter finds any new issues, then we can add those as commits before the test addition commit.)

amitech commented 3 years ago

@purpleidea let me know if it is still relevant? I can take this one.

royadaneshi commented 1 year ago

Hello @purpleidea
I added new test similar to the test-gometalinter.sh in golangci-lint and I created a pull request.

purpleidea commented 1 year ago

FYI: i replied in your PR.