search

purpleidea / mgmt

Next generation distributed, event-driven, parallel config management!
https://purpleidea.com/tags/mgmtconfig/
GNU General Public License v3.0
3.63k stars 313 forks source link

Tftp server resource shouldn't serve until CheckApply runs successfully #577

Open purpleidea opened 4 years ago

purpleidea commented 4 years ago

Basically we're in the DAG, so make sure we've let all the other resources (like files) get built (that might be used for the file server) before the server sends anything out. We could either block or just not return anything yet.

As an aside, does the rf.ReadFrom bit not get cancelled properly on close??

hariTiwari442 commented 1 year ago

Hey! Please assign this to me! Thanks.

purpleidea commented 1 year ago

No need to assign it, just send a patch, nobody is working on this at the moment! Cheers!

hariTiwari442 commented 1 year ago

Hi I read introductory Blog related to the mgmt and your TODO list, Although I am understanding the whole project but to understand whole code and flow and logic, Can you please create some low difficulty level and easy fix issue so that I can learn the code base while solving the easy issue.

purpleidea commented 1 year ago

Yes I can-- can you please give me a rough idea of your golang experience level, and how many hours you'd like to initially devote to the project? This was I can help with something more appropriate for you. Cheers

hariTiwari442 commented 1 year ago

Hi currently i am working in golang from last 4 months but previously i working on different web technologies like Node and others, i am also done competitive programming with with c++ and when i saw your DAG explanation i really got excited to know this project more

purpleidea commented 1 year ago

@hariTiwari442 Perhaps you could try implementing a simple mgmt function, like is_virtual for example? (To determine if something is a virtual machine or not.)

It's challenging to find beginner golang projects, but I think this might be a good bet. Alternatively implement a simple resource like sysctl or something else you have in mind.

hariTiwari442 commented 1 year ago

Hi, Thanks for your guide, Sure once I complete the code base, I will start with simple functions and resources thanks.