search

purpleidea / mgmt

Next generation distributed, event-driven, parallel config management!
https://purpleidea.com/tags/mgmtconfig/
GNU General Public License v3.0
3.67k stars 315 forks source link

test: Add GitHub Actions test support #636

Closed frebib closed 3 years ago

frebib commented 3 years ago

Contains some other small cleanups, and some necessary improvements to make the CI formatting a bit tidier and cleaner.

frebib commented 3 years ago

I can't request reviewers @purpleidea

cc @evrardjp based on your work

frebib commented 3 years ago

Seems the test-shell is failing. I've not looked into why yet but I presume it's either a flaky test or the test is broken https://github.com/frebib/mgmt/runs/1889240885?check_suite_focus=true#step:6:129

frebib commented 3 years ago

Whilst I think about it (more of a note to myself more than anything) we need a step to send an IRC message the same way that Travis does

frebib commented 3 years ago

Seems the test-shell is failing. I've not looked into why yet but I presume it's either a flaky test or the test is broken https://github.com/frebib/mgmt/runs/1889240885?check_suite_focus=true#step:6:129

I'm starting to think that these shell tests are a bit flaky. I ran them locally and the one that failed in CI passed fine locally, but a couple of others later on failed for unrelated and silly reasons (couldn't bind, port already in use)

purpleidea commented 3 years ago

So I merged all of this. yay \o/ I snuck in one additional commit after commit #4, and I rebased #5 ... Hope that's okay. One question about: https://github.com/purpleidea/mgmt/pull/636#discussion_r575913084 And also why did you disable the race tests, should we add those back in? Lastly, it's true that some of the shell tests are flaky. I can explain, but we should just be sad about them for now.

Thank you for the patches!

purpleidea commented 3 years ago

PS: since github is dumb, it apparently is not smart enough to show even a partial "merged". Sorry everyone.