Closed S-ign closed 3 years ago
Side note, re discussion in IRC:
I noticed that one of the tests failed in an unusual place in this PR... And I said, gah, I hope it's not a race. So I dug into it, and it turns out it was caused by a bug in your code! (yay, no our fault!) So the good news is the tests work, the bad news is I think we could have caught this issue in a more obvious place. So I added a new commit that should help new developers out by providing a clearer error message.
https://github.com/purpleidea/mgmt/commit/887d374c530915565b0257e6ac6f8c0cda232067
You'll want to rebase your branch against this commit which is now in git master.
Cheers!
@S-ign Hey-- I'm not going to do a full review yet-- I'd like you to first make a small examples/lang/whatever.mcl that uses this function, and confirm you got it doing what you expect. This should replace the copied example that you committed in this PR.
When you've succeeded, please update this PR and put a comment here with the command you used to run this example =D
Thanks!
(For anyone else reading, @S-ign came to us for a learning experience, so this is not the traditional review process.)
Tips:
please read the style guide before submitting your patch: docs/style-guide.md
commit message titles must be in the form:
topic: Capitalized message with no trailing period
or:
topic, topic2: Capitalized message with no trailing period
or format a single golang file correctly:
Thanks for contributing to mgmt and welcome to the team!