purpleidea / mgmt

Next generation distributed, event-driven, parallel config management!
https://purpleidea.com/tags/mgmtconfig/
GNU General Public License v3.0
3.58k stars 311 forks source link

Set up golangci-lint linter based on gometalinter #669

Closed ginywiny closed 3 years ago

ginywiny commented 3 years ago

Test HIGHLY based on test-gometalinter, as it is used to lint the same files, except where golangci-lint is used instead of gometalinter.

Note: When golangci-lint uses the --skip-files flag, it still lints the file, but simply doesn't display the linting results. Lastly, older version of the test was linting individual .go files instead of .go, but this ran a lot slower. For this reason, .go is used instead.

Comments and TODOs from the previous gometalinter test file were kept in case new linters are being used.

purpleidea commented 3 years ago

Looks like lots of tests are failing, and this is nine commits... I think you probably want to squash this down a bit =D LMK if you're not sure why the tests are failing.

Cheers!