Closed purpleidea closed 2 years ago
@frebib
https://github.com/frebib/mgmt/commits/feat/go-mod-fixes Here are my fixes. Please look over the last commit as I removed anything that seemed no longer applicable. Feel free to exclude any of my removals as you see fit, then hopefully we can get this merged
~You're also going to want to remove the rest of .gitmodules
because any partial vendor directory will (probably) confuse go-mod. It'll either be ignored outright or cause build failures depending on how you invoke go build -mod=???
~
Updated my branch
Nice, you rebased on top. Fantastic. Will look later tonight.
I found that with go modules, gometalinter fails to install, for some reason. You may need this commit to make the tests pass https://github.com/frebib/mgmt/commit/8fde6aaac75b740fa646d8301510acaffe3fb4d6
Replaced by https://github.com/purpleidea/mgmt/pull/674
I'm incredibly annoyed that go modules are being forced onto us, as the old system with vendor/ and git submodules worked great. Unfortunately, so much FUD around git submodules, even by well-known, highly paid engineers has caused this solution to be deemed most unacceptable.
So much for the golang compatibility promise-- turns out it doesn't apply to the useful parts that we actually care about like this.
Thanks to frebib for his help with this suffering.
Tips:
please read the style guide before submitting your patch: docs/style-guide.md
commit message titles must be in the form:
topic: Capitalized message with no trailing period
or:
topic, topic2: Capitalized message with no trailing period
or format a single golang file correctly:
Thanks for contributing to mgmt and welcome to the team!