search

purpleidea / mgmt

Next generation distributed, event-driven, parallel config management!
https://purpleidea.com/tags/mgmtconfig/
GNU General Public License v3.0
3.58k stars 311 forks source link

Build mgmt from a Fedora container #713

Closed laurent-indermuehle closed 1 year ago

laurent-indermuehle commented 1 year ago

This PR provides a way to build mgmt for Fedora using a container. When following the quick start guide for the first time, none of the offered methods to build mgmt worked.

To ensure regel 6.1 is installed instead of the 7.0, I had to refactor test/util.sh and misc/make-deps.sh. This is why the in_ci method became in_env.

Maybe it would have been better to just rebuild the RPM for latest version of Fedora. But I prefer to use a container to keep my workstation clean. Another idea would be to use github action.

In the meantime this provide a solution, today, for newcomers.

purpleidea commented 1 year ago

LGTM, let's see what CI says. Cheers!

purpleidea commented 1 year ago

./test/test-markdownlint.sh FAILED

docs/quick-start-guide.md:100: MD012 Multiple consecutive blank lines docs/quick-start-guide.md:115: MD012 Multiple consecutive blank lines docs/quick-start-guide.md:103: MD013 Line length

Also please change:

Buildah :

to:

Buildah:

laurent-indermuehle commented 1 year ago

Done. Thanks @purpleidea for the review.

purpleidea commented 1 year ago

Merged, thank you very much!

Now that you've got your first patch in, lmk if you need help deciding on what to do for patch number two! Each one gets more fun.

Cheers! :trophy:

laurent-indermuehle commented 1 year ago

@purpleidea Thank you for your trust ! And thanks for the proposition for patch n°2, I'll keep in touch on Matrix.