search

purpleidea / mgmt

Next generation distributed, event-driven, parallel config management!
https://purpleidea.com/tags/mgmtconfig/
GNU General Public License v3.0
3.67k stars 315 forks source link

Proposed cleanup merge for https://github.com/purpleidea/mgmt/pull/723 #725

Closed purpleidea closed 10 months ago

purpleidea commented 11 months ago

@gelisam Here's my proposed merge for your excellent #723. I did some small cleanups and squashing, and everything passes now. NOTE: that due to an existing race (not yet fixed) it does sometimes deadlock in CI, but it seems to work great locally at least for now.

purpleidea commented 11 months ago

I was wrong about the reason for the failure. It's actually because we now use test.one_instance_a() in more than one test... When called individually, things are fine, but because that fact uses global state to check if it's called twice, when we run the tests all together it panics! (correctly so!)

haha!

So let me fix that up so we can still test this behaviour but not fail things because of it. Neat!

purpleidea commented 11 months ago

Fixed!

@gelisam If you don't object, I will merge this shortly. I've kept the main commit in your name even though it is squashed and has some slight formatting and other changes.

purpleidea commented 10 months ago

Merged \o/