purpleidea / mgmt

Next generation distributed, event-driven, parallel config management!
https://purpleidea.com/tags/mgmtconfig/
GNU General Public License v3.0
3.47k stars 308 forks source link

lang/types: Fail build if stringer run from GOROOT #735

Closed ollytom closed 5 months ago

ollytom commented 6 months ago

If stringer is run from GOROOT, it can't find any packages; same error as in https://go.dev/issue/31843. And since GOCACHE is always ignored (see issue above) we can have a bare go generate command.

purpleidea commented 5 months ago

Awesome, thank you! Assuming this didn't break CI, I will merge shortly with a two char commit message change so it passes CI. (as seen in bug/stringer)

purpleidea commented 5 months ago

Merged in d47869ac2f1addf23a55bc0a6f4c5f2ea25ecfb4

Thanks and welcome officially to the project!