purpleidea / puppet-gluster

puppet module for gluster
https://ttboj.wordpress.com/code/puppet-gluster/
GNU Affero General Public License v3.0
101 stars 51 forks source link

Better support for Ubuntu #61

Open gl00ten opened 9 years ago

gl00ten commented 9 years ago

from the simple

class { '::gluster::simple': }

I get:

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Could not find class puppet::facter for gfs1 on node gfs1

So I used the "include_puppet_facter => false" parameters like so:

class site::glusterfs_simple {
  class { '::gluster::params': include_puppet_facter => false, }

  class { '::gluster::simple': path => '/data/content/', }

  Class['::gluster::params'] -> Class['::gluster::simple']
}

And now I get:

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Operating system: 'Ubuntu' not yet supported. at /etc/puppet/modules/gluster/manifests/repo.pp:78 on node gfs1

Now I'm wondering if I did something wrong by defining that parameter as false, as I only found the puppet::facter being declared at the vagrant directory.

Is this application correct? If not, what I did wrong?

If yes, what parts of the code need change to support Ubuntu at this point?

(edit: I also tried the extended way to apply this class, as is on the manual, with same results)

cova-fe commented 9 years ago

Same problem here, maybe because Ubuntu is not yet supported? but where puppet::facter class is supposed to be found?

Thanks.

cova-fe commented 9 years ago

As workaround, I disabled the use of repo feature and installed packages manually

purpleidea commented 9 years ago

If you want puppet::facter, it's in here: https://github.com/purpleidea/puppet-puppet however, while ubuntu should basically work, nobody has stepped up to test it / etc...

What's missing? 1) If you want automatic package finding/downloading, we'll need a small patch here: https://github.com/purpleidea/puppet-gluster/blob/master/manifests/repo.pp#L78

2) If you want to make sure all the ubuntu specific variables have the correct values, you'll need to add a small yaml file here: https://github.com/purpleidea/puppet-gluster/tree/master/data/params/Debian

3) You'll need to do some testing :)

I think that's it, I'm happy to review/merge patches. Cheers