search

purpleidea / vagrant-builder

an elegant method for making base images for vagrant-libvirt
GNU Affero General Public License v3.0
42 stars 23 forks source link

Doc updates #16

Closed vvaldez closed 9 years ago

purpleidea commented 9 years ago

Hey @vvaldez thanks for another doc patch, this is awesome!

Before I do a more thorough review/merge, could you rebase this against current git master and squash it into a relevant number of patches (one or as many as you like, but please remove the merge commits).

Thanks! James

vvaldez commented 9 years ago

Sure! Let me figure that out.

vvaldez commented 9 years ago

How about now?

purpleidea commented 9 years ago

@vvaldez Patch looks rebased nicely Great!!

Looking at the content, a number of sections (looks like the terminal output mostly) are indented with spaces, but it's not necessary for any reason I know... Did I miss something?

The table is a cute touch, but I don't think it's formatted correctly... run 'make docs' and it should generate a copy you can view. The $ dissappears, and other things...

LMK, Thanks!

vvaldez commented 9 years ago

Oops, I didn't try to make the docs. The indent was to distinguish between prompt and output since the getfacl uses hashes, but it's not necessary. I'll fix.

purpleidea commented 9 years ago

On Thu, Jul 9, 2015 at 10:03 AM, Vinny Valdez notifications@github.com wrote:

Oops, I didn't try to make the docs. The indent was to distinguish between prompt and output since the getfacl uses hashes, but it's not necessary. I'll fix.

Ah, got it. We should probably leave it without the indents so it looks exactly as normal terminal output would. Whether that looks sane or not is getfact's fault, now ours.

LMK when I should review again.

vvaldez commented 9 years ago

How does this look?

purpleidea commented 9 years ago

Done review. Needs a few fixes. Thanks again for the patch!

vvaldez commented 9 years ago

Ready for review again.

purpleidea commented 9 years ago

w00t!

Merged, thanks!