search

purpleidea / vagrant-builder

an elegant method for making base images for vagrant-libvirt
GNU Affero General Public License v3.0
42 stars 23 forks source link

Consistently use the qcow2 image format #20

Closed wzzrd closed 8 years ago

wzzrd commented 8 years ago

Formerly, the scripts assuming raw images in some places, qcow2 images in other places. This change explicitly makes all scripts everywhere use the qcow2 format rather than raw and unbreaks the invocation of virt-builder.

On irc we discussed setting the default format to raw, but considering the resulting image format is qcow2 anyway, and qcow2 is referenced in many more places in the script than raw, I chose to make vagrant-builder consistently use qcow2 instead of consistently use raw.

Should resolve #19

purpleidea commented 8 years ago

@wzzrd Thanks for the patch! If you can confirm that you tested this and it works as you expect, then it LGTM :)

If you also test at least one non-iso build, that would be a bonus too.

Cheers, James

wzzrd commented 8 years ago

Tested with rhel-7.2-iso and centos-7.2. Both work fine now.

purpleidea commented 8 years ago

Merged :)